Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sonarqube] Fix for issue #10195 #10196

Closed
wants to merge 138 commits into from
Closed

[stable/sonarqube] Fix for issue #10195 #10196

wants to merge 138 commits into from

Conversation

melissapalmer
Copy link
Contributor

What this PR does / why we need it: allow latest docker image for sonarqube to be used with this chart fix issue #10195

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2018
@melissapalmer melissapalmer mentioned this pull request Dec 21, 2018
Closed
@melissapalmer melissapalmer changed the title Fix for issue #10195 [stable/sonarqube] Fix for issue #10195 Dec 21, 2018
rjkernick
rjkernick suggested changes Dec 28, 2018
View reviewed changes
stable/sonarqube/Chart.yaml Outdated
@@ -1,7 +1,7 @@
name: sonarqube
description: Sonarqube is an open sourced code quality scanning tool
version: 0.10.3
appVersion: 6.7.6
version: 0.10.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the minor version instead as this changes the underlying container version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjkernick bumping this version is causing issues, as has already been done on your master branch. I have attempted to sort out but not all the sign off requirements seem to be failing.
I have attempted to correct... but it is still complaining.

Please can you assist, as I am unaware how to sort this out now, seems a shame to not get this work in cause of version change.

@rjkernick
Copy link
Collaborator

/ok-to-test

@rjkernick
Copy link
Collaborator

/assign

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 2, 2019
@melissapalmer
Copy link
Contributor Author

/retest

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2019
@melissapalmer
Copy link
Contributor Author

@rjkernick I need some help to sort out the DCO issues from the merge request. please

@rjkernick
Copy link
Collaborator

Details on the DCO here: https://github.com/helm/charts/pull/10196/checks?check_run_id=45484289
Has a couple commands that should sort it out.

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2019
@melissapalmer
Copy link
Contributor Author

Hi @rjkernick I have attempted these commands and its just making things worse as

the commits by others are now being signed off my me and its not happy. for example below

Junior [email protected]", but got "cpanato [email protected]".
Commit sha: f6f2a9e, Author: Carlos Tadeu Panato Junior, Committer: Melissa Palmer; Expected "Carlos Tadeu Panato Junior [email protected]", but got "cpanato [email protected]".
Commit sha: 4f796b7, Author: Carlos Tadeu Panato Junior, Committer: Melissa Palmer; Expected "Carlos Tadeu Panato Junior [email protected]", but got "cpanato [email protected]".

I started with 2 commit issues, did the commands as recommended and it then when to 44 issues
I now redid them and getting 96 issues.

I am not sure how to sort this out now.

@helm-bot helm-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2019
melissapalmer and others added 12 commits January 2, 2019 18:08
@melissapalmer
from merge
9de623c 
Signed-off-by: Melissa Palmer <[email protected]>
@melissapalmer
bump minor version as requested
732d8fc 
Signed-off-by: Melissa Palmer <[email protected]>
@davidkarlsen @melissapalmer
upgrade elasticsearch (#10326)
92c7621 
Signed-off-by: David J. M. Karlsen <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@andresbono @melissapalmer
Add Ghost parameter to specify the URL protocol (#10330)
c522f70 
Signed-off-by: Andrés Bono <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@tompizmor @melissapalmer
[bitnami/postgresql] Fix creating initdb scripts from values.yaml (#1…
da36b0a 
…0332)

Signed-off-by: tompizmor <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@den-is @melissapalmer
use proper k8s image registry (#10325)
a106330 
as by kubernetes/kubernetes#54174

Signed-off-by: Denis Iskandarov <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@osrecki @melissapalmer
[stable/redis] Process template directives in affinity parameters (#1…
d5ef2a9 
…0312)

* [stable/redis] Process template directives in affinity parameters

Signed-off-by: Dinko Osrecki <[email protected]>

* [stable/redis] Update README

Signed-off-by: Dinko Osrecki <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@sylr @melissapalmer
Trim global section to avoid empty line to be indented (#10204)
d8de771 
This fix prometheus.yml output display when using `kubectl get configmap prometheus-server`

Signed-off-by: Sylvain Rabot <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@juan131 @melissapalmer
[stable/rabbitmq] Add Ingress Path parameter (#10336)
208657c 
* [stable/rabbitmq] Add Ingress Path parameter

Signed-off-by: juan131 <[email protected]>

* Fix Typo

Signed-off-by: juan131 <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@juan131 @melissapalmer
[stable/prestashop] Add ingress (#10335)
ff03077 
* [stable/prestashop] Add ingress

Signed-off-by: juan131 <[email protected]>

* Remove debug message

Signed-off-by: juan131 <[email protected]>

* Update labels to new format

Signed-off-by: juan131 <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@bklang @melissapalmer
Tag roles for master and data (#10337)
479b2b2 
This follows role conventions seen in other Helm charts and allows graphing to break out activity stats per role

Signed-off-by: Ben Klang <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@juan131 @melissapalmer
[stable/mariadb] Add support to existing configMaps as init scripts (#…
03e5756 
…10338)

Signed-off-by: juan131 <[email protected]>
Signed-off-by: Melissa Palmer <[email protected]>
@helm-bot helm-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 2, 2019
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: melissapalmer
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rjkernick

If they are not already assigned, you can assign the PR to them by writing /assign @rjkernick in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@melissapalmer
Merge pull request #3 from helm/master
ef1e158 
master to this fork again
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2019
@melissapalmer
Copy link
Contributor Author

Closing this PR will attempt to submit another as am unable to sort out the DCO from

@melissapalmer
Copy link
Contributor Author

reopening as I have the same issue when opening a new PR now anyawys

@melissapalmer melissapalmer reopened this Jan 2, 2019
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2019
@melissapalmer
Copy link
Contributor Author

Closing this PR will attempt to submit another as am unable to sort out the DCO from

@melissapalmer melissapalmer mentioned this pull request Jan 2, 2019
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjkernick rjkernick rjkernick requested changes

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees

@rjkernick rjkernick

Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/sonarqube] overiding image.tag=7.4-community does not install default sonarqube plugins